Skip to content

CurieBLE: BLE.scan() should scan with duplicate filter #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandeepmistry opened this issue Dec 29, 2016 · 5 comments
Closed

CurieBLE: BLE.scan() should scan with duplicate filter #368

sandeepmistry opened this issue Dec 29, 2016 · 5 comments
Assignees
Milestone

Comments

@sandeepmistry
Copy link
Contributor

In https://github.com/01org/corelibs-arduino101/blob/master/libraries/CurieBLE/examples/central/scan/scan.ino

BLE.scan();

scans without filter, however I expect it to scan with a duplicate filter.

@SidLeung
Copy link
Contributor

Track by Jira 802

@kitsunami
Copy link

Addressed by #457

@sandeepmistry
Copy link
Contributor Author

This is a bit better with the 2.0.1 RC1 release, however the logic to enable the duplicate filtering is inverted.

I've submitted PR #476 to address this.

@SidLeung
Copy link
Contributor

Please note that PR #476 is superseded by the follow PR,

https://jira.ndg.intel.com/browse/ATLEDGE-896

@sandeepmistry
Copy link
Contributor Author

This looks good now with the 2.0.2 RC JSON @SidLeung provided me. Closing

The scan.ino example only reports discovered peripherals once as expected and the scan_callback.ino example reports every advertisement.

However, as @SidLeung mentioned BLE.scan() does not report the scan response as I expected. I'll open a separate issue to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants