Refactor port selection after 1200bps touch upload

[facchinm]

New behaviour:
if upload failed or we are uploading through a "Programming" port (that does not disappear), leave the user selected port selected.
if upload succeded and we are using 1200bps touch, wait for the first port that reappears, and if nothing reappears after the timeout select the bootloader port.

Fixes #3495

[ArduinoBot]

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8218-BUILD-810-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8218-BUILD-810-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8218-BUILD-810-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8218-BUILD-810-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8218-BUILD-810-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

[matthijskooijman]

I haven't looked at the code in detail, but can't we match the port based on the USB identifier (I mean the connection path / USB port, not the vidpid).

[facchinm]

Matching on the usb identifier would be THE BEST; I tried that approach once with libusb hotplug but it didn't really work 🙂 Anyway, any help on this would be greatly appreciated.

[PilotinControl25]

Ok so this build works under windows Vista by pressing the reset button and it uploads....any way of not doing that each time?

[facchinm]

@PilotinControl25 which board are you targeting?

[PilotinControl25]

I am using the Mell Bell Pico arduino compatible board which they are using the Leonardo style board. However each time i plug the board in it gets assigned a different port. I tried assigning the port number via device manager and still does not work. Only with this style board. My other boards do not change ports. The fix does not work. I am using windows vista.

[facchinm]

Thanks @PilotinControl25 for testing. Would you mind sharing a screencast of an upload? Or even the verbose output could be enough to try to replicate the issue

[facchinm]

I've been able to reproduce the original problem on WIndows XP by switching between a sketch with #include "Mouse.h" and one without.
I confirm that this patch solves this kind of issue.
If the board changes port number after every download it should just behave in the same way unless the driver takes longer than 5 seconds to load (it's a problem on its own, but not something we can solve I believe)

[cmaglie]

The fix looks good, it should cover new cases without touching the existing one. I'm merging this one so it may get broader testing on the hourly build.