-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix tools discovery by strictly following json data when available #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…al properties map
This helps the understanding of next commits
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5199-BUILD-584-linux32.tar.xz ℹ️ The |
I tested build 584 with the following URLs:
https://raw.githubusercontent.com/per1234/MightyCore/add-tools/package_MCUdude_MightyCore_index.json
In all cases the installation proceeded correctly. When the specified tool version was already installed that copy was used. The correct tools were selected for compilation, upload, and Burn Bootloader with MightyCore and Arduino AVR Boards. When a core was updated with a new tool version if the previous tool version was referenced it was left installed, otherwise it was removed. |
Should fix #5042 and #5168.
(in particular #5168 would need more work to implement my proposal of
coreDependencies
field into package_index.json to be a complete solution, IMHO)See also #5197.
/cc @facchinm @PaulStoffregen @matthijskooijman @per1234 @jantje