Skip to content

Add specifier to generated tool property keys #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Apr 1, 2016

By doing so, runtime variable are resolved by using the board specific tools

real life example:

  • Intel i585 defines sketchUploader (version 1.6.2)
  • Intel arc32 defines sketchUploader (version 1.6.4)
  • runtime.tools.sketchUploader.path gets the value of the last one processed

with this PR

runtime.tools.sketchUploader.path.Intel.arc32 and runtime.tools.sketchUploader.path.Intel.i586 get created

when resolving {runtime.tools.sketchUploader}, the routine searches for a key runtime.tools.sketchUploader.Vendor.Architecture

If found, the value is obtained by {runtime.tools.sketchUploader.Vendor.Architecture}.getKey(), which always contains the required value.
If no value is found, the old method is applied

facchinm added a commit to facchinm/arduino-builder that referenced this pull request Jul 4, 2016
by doing so, runtime variable are resolved by using the board specific tools

real life example:
- Intel i585 defines sketchUploader (version 1.6.2)
- Intel arc32 defines sketchUploader (version 1.6.4)
- runtime.tools.sketchUploader.path gets the value of the last one processed

with this PR

runtime.tools.sketchUploader.path.Intel.arc32 and runtime.tools.sketchUploader.path.Intel.i586 get created

when resolving {runtime.tools.sketchUploader}, the routine searches for a key runtime.tools.sketchUploader.Vendor.Architecture

If found, the value is obtained by {runtime.tools.sketchUploader.Vendor.Architecture}.getKey(), which always contains the required value.
If no value is found, the old methos is applied
@facchinm
Copy link
Member Author

facchinm commented Aug 2, 2016

Superseded by #5199

@facchinm facchinm closed this Aug 2, 2016
@cmaglie cmaglie added this to the Release 1.6.11 milestone Aug 3, 2016
@facchinm facchinm deleted the add_specifier branch September 20, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants