Skip to content

Reuse QSPIF Block Device instance from the core if exist #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 15, 2021

The define COMPONENT_4343W_FS is not strictly related to the QSPI device but it is the main reason of the rework on the mbed side that has caused this init side effect, so in the end i think it is a good way to keep the changes aligned.

…FS is used instead of COMPONENT_4343W and the QSPI BlockDevice is initialized in the core
@pennam pennam requested a review from facchinm July 15, 2021 09:28
@pennam
Copy link
Contributor Author

pennam commented Jul 15, 2021

@manchoz

@github-actions
Copy link

Memory usage change @ 1c932fb

Board flash % RAM for global variables %
arduino:mbed:envie_m7 💚 -64 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Qspi_Flash
flash
% examples/OTA_Qspi_Flash
RAM for global variables
% examples/OTA_SD_Portenta
flash
% examples/OTA_SD_Portenta
RAM for global variables
% examples/OTA_Usage_Portenta
flash
% examples/OTA_Usage_Portenta
RAM for global variables
%
arduino:mbed:envie_m7 -64 -0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Qspi_Flash<br>flash,%,examples/OTA_Qspi_Flash<br>RAM for global variables,%,examples/OTA_SD_Portenta<br>flash,%,examples/OTA_SD_Portenta<br>RAM for global variables,%,examples/OTA_Usage_Portenta<br>flash,%,examples/OTA_Usage_Portenta<br>RAM for global variables,%
arduino:mbed:envie_m7,-64,-0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam merged commit 43e3939 into arduino-libraries:main Jul 15, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants