Skip to content

[WIP] Reuse QSPIF Block Device from Wiced driver #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

manchoz
Copy link

@manchoz manchoz commented Jul 14, 2021

This PR is a tentative fix the QSPIF_BD_ERROR_DEVICE_NOT_UNIQUE = -4006 error at ::begin() because of conflicting instantiation of the QSPIFBlockDevice object on the same QSPIF Device.

@github-actions
Copy link

Memory usage change @ 88e9cad

Board flash % RAM for global variables %
arduino:mbed:envie_m7 💚 -16 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Qspi_Flash
flash
% examples/OTA_Qspi_Flash
RAM for global variables
% examples/OTA_SD_Portenta
flash
% examples/OTA_SD_Portenta
RAM for global variables
% examples/OTA_Usage_Portenta
flash
% examples/OTA_Usage_Portenta
RAM for global variables
%
arduino:mbed:envie_m7 -16 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Qspi_Flash<br>flash,%,examples/OTA_Qspi_Flash<br>RAM for global variables,%,examples/OTA_SD_Portenta<br>flash,%,examples/OTA_SD_Portenta<br>RAM for global variables,%,examples/OTA_Usage_Portenta<br>flash,%,examples/OTA_Usage_Portenta<br>RAM for global variables,%
arduino:mbed:envie_m7,-16,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@facchinm facchinm requested a review from pennam July 15, 2021 07:47
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qspi_bd is available only since 2.3.1 core. I think that we should go for a safer solution that builds also on old cores. I'm now testing this https://github.com/arduino-libraries/Arduino_Portenta_OTA/compare/main...pennam:qspi_init?expand=1

@manchoz
Copy link
Author

manchoz commented Jul 15, 2021

Superseded by #12.

Closing.

Thanks @pennam!

@manchoz manchoz closed this Jul 15, 2021
@manchoz manchoz deleted the reuse_qspi_bd branch July 26, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants