Skip to content

Minor: switch informative WiFi debug prints from ERROR to INFO #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Minor: switch informative WiFi debug prints from ERROR to INFO #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11467ef
WiFi debug: Switch WiFi status ESP and WiFi Firmware debug prints fro…
pennam Oct 13, 2022
5e2279b
WiFi debug: Switch "Attempting reconnection" debug print from ERROR t…
pennam Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Arduino_WiFiConnectionHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ NetworkConnectionState WiFiConnectionHandler::update_handleInit()
return NetworkConnectionState::ERROR;
}
#if !defined(__AVR__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've commented on this before, but you can really remove all those #if !defined(__AVR__) statements, since AVR is not going to be supported as a target platform, due to flash size constraints.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think will do a general cleanup before releasing a new version of the library 😉

Debug.print(DBG_ERROR, F("Current WiFi Firmware: %s"), WiFi.firmwareVersion());
Debug.print(DBG_INFO, F("Current WiFi Firmware: %s"), WiFi.firmwareVersion());
#endif

#if defined(WIFI_FIRMWARE_VERSION_REQUIRED)
Expand All @@ -82,7 +82,7 @@ NetworkConnectionState WiFiConnectionHandler::update_handleInit()
#endif

#else
Debug.print(DBG_ERROR, F("WiFi status ESP: %d"), WiFi.status());
Debug.print(DBG_INFO, F("WiFi status ESP: %d"), WiFi.status());
WiFi.disconnect();
delay(300);
WiFi.begin(_ssid, _pass);
Expand Down Expand Up @@ -132,7 +132,7 @@ NetworkConnectionState WiFiConnectionHandler::update_handleConnected()
if (_keep_alive)
{
#if !defined(__AVR__)
Debug.print(DBG_ERROR, F("Attempting reconnection"));
Debug.print(DBG_INFO, F("Attempting reconnection"));
#endif
}

Expand Down