-
Notifications
You must be signed in to change notification settings - Fork 37
Minor: switch informative WiFi debug prints from ERROR to INFO #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to DBG_INFO
is definitely a better solution ;)
@@ -67,7 +67,7 @@ NetworkConnectionState WiFiConnectionHandler::update_handleInit() | |||
return NetworkConnectionState::ERROR; | |||
} | |||
#if !defined(__AVR__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've commented on this before, but you can really remove all those #if !defined(__AVR__)
statements, since AVR is not going to be supported as a target platform, due to flash size constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i think will do a general cleanup before releasing a new version of the library 😉
Memory usage change @ 5e2279b
Click for full report table
Click for full report CSV
|
Some debug prints in the WiFI connection handler are marked as
ERROR
, but the content of the string is not a real error, thought this prints can be disabled usingsetDebugMessageLevel(-1);
i think it is better to move them to levelINFO