Remove AVR compile options to improve code clarity #311

pennam · 2022-03-11T07:42:58Z

This PR should to the job for #299

codecov-commenter · 2022-03-11T07:44:59Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8e654f9) 95.00% compared to head (8373e90) 95.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          27       27           
  Lines        1220     1220           
=======================================
  Hits         1159     1159           
  Misses         61       61

Files	Coverage Δ
src/cbor/CBOREncoder.h	`100.00% <ø> (ø)`
src/property/Property.cpp	`89.74% <ø> (ø)`
src/property/Property.h	`89.47% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennam · 2022-03-11T10:12:34Z

CI failure due to the M4 build. It will be fixed once #310 will be merged and this rebased on master.

pennam · 2022-05-09T07:23:01Z

rebased on master to fix m4 build ci error

aentinger

LGTM 👍

You can also remove installation of Arduino_AVRSTL as CI build dependency from .github/workflows/compile-examples.yml.

github-actions · 2023-10-09T14:50:29Z

Memory usage change @ 8373e90

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_giga:giga`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nicla:nicla_vision`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp32:esp32:esp32`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp8266:esp8266:huzzah`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ArduinoIoTCloud-Advanced` flash	%	`examples/ArduinoIoTCloud-Advanced` RAM for global variables	%	`examples/ArduinoIoTCloud-Basic` flash	%	`examples/ArduinoIoTCloud-Basic` RAM for global variables	%	`examples/ArduinoIoTCloud-Callbacks` flash	%	`examples/ArduinoIoTCloud-Callbacks` RAM for global variables	%	`examples/ArduinoIoTCloud-Schedule` flash	%	`examples/ArduinoIoTCloud-Schedule` RAM for global variables	%	`examples/utility/ArduinoIoTCloud_Travis_CI` flash	%	`examples/utility/ArduinoIoTCloud_Travis_CI` RAM for global variables	%	`examples/ArduinoIoTCloud-DeferredOTA` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` RAM for global variables	%	`examples/utility/Provisioning` flash	%	`examples/utility/Provisioning` RAM for global variables	%	`examples/utility/SelfProvisioning` flash	%	`examples/utility/SelfProvisioning` RAM for global variables	%
`arduino:esp32:nano_nora`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_giga:giga`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nicla:nicla_vision`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp32:esp32:esp32`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp8266:esp8266:huzzah`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_giga:giga,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,

pennam requested a review from aentinger March 11, 2022 07:43

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 11, 2022

pennam force-pushed the remove_avr branch from 027f8af to b9bf2c4 Compare May 9, 2022 07:22

pennam self-assigned this May 9, 2022

arduino-libraries deleted a comment from github-actions bot Nov 3, 2022

pennam force-pushed the remove_avr branch 4 times, most recently from 3cdad83 to f905cfc Compare March 6, 2023 12:43

arduino-libraries deleted a comment from github-actions bot Mar 6, 2023

pennam requested review from facchinm and alranel March 6, 2023 13:06

aentinger approved these changes Apr 3, 2023

View reviewed changes

Remove __AVR__ compile options to improve code clarity

8373e90

pennam force-pushed the remove_avr branch from f905cfc to 8373e90 Compare October 9, 2023 14:15

arduino-libraries deleted a comment from github-actions bot Oct 9, 2023

pennam merged commit 6a9acc2 into arduino-libraries:master Oct 9, 2023

pennam mentioned this pull request Dec 22, 2023

Remove #if !defined(__AVR__) to improve code clarity. #299

Closed

pennam mentioned this pull request Feb 2, 2024

Remove remaining ARDUINO_AVR_UNO_WIFI_REV2 configuration defines #413

Merged

pennam deleted the remove_avr branch May 17, 2024 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove AVR compile options to improve code clarity #311

Remove AVR compile options to improve code clarity #311

pennam commented Mar 11, 2022

codecov-commenter commented Mar 11, 2022 •

edited by codecov bot

Loading

pennam commented Mar 11, 2022

pennam commented May 9, 2022

aentinger left a comment

github-actions bot commented Oct 9, 2023

Remove __AVR__ compile options to improve code clarity #311

Remove __AVR__ compile options to improve code clarity #311

Conversation

pennam commented Mar 11, 2022

codecov-commenter commented Mar 11, 2022 • edited by codecov bot Loading

Codecov Report

pennam commented Mar 11, 2022

pennam commented May 9, 2022

aentinger left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2023

Remove AVR compile options to improve code clarity #311

Remove AVR compile options to improve code clarity #311

codecov-commenter commented Mar 11, 2022 •

edited by codecov bot

Loading