PORTENTA_H7_M4: Remove M4 core from supported build options #310

pennam · 2022-03-08T20:51:51Z

With the actual configuration of the library OTA is not enabled for PORTENTA_H7_M4:

Lines 105 to 115 in 45d5672

    
           #if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_NICLA_VISION) 
        
             #define OTA_STORAGE_PORTENTA_QSPI   (1) 
        
           #else 
        
             #define OTA_STORAGE_PORTENTA_QSPI   (0) 
        
           #endif 
        
           #if (OTA_STORAGE_SFU || OTA_STORAGE_SSU || OTA_STORAGE_SNU || OTA_STORAGE_PORTENTA_QSPI) && !defined(ARDUINO_AVR_UNO_WIFI_REV2) 
        
             #define OTA_ENABLED             (1) 
        
           #else 
        
             #define OTA_ENABLED             (0) 
        
           #endif

so is it safe to not compile portenta_h7_onOTARequest() function for the M4 build.

This is also a possible fix for the compile-examples failure of the last release caused by restricting the support of Arduino_Portenta_OTA only to the M7 core:

https://github.com/arduino-libraries/Arduino_Portenta_OTA/blob/0652134e737b67575e2d1c41cb9fac238922ebd0/src/Arduino_Portenta_OTA_Config.h#L27-L31

github-actions · 2022-03-08T21:17:07Z

Memory usage change @ 97e6472

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	N/A	N/A	N/A	N/A
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nicla:nicla_vision	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nicla:nicla_vision	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrgsm1400	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp8266:esp8266:huzzah	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

aentinger

LGTM 👍

…ule is not working on the M4

github-actions · 2022-03-09T14:49:44Z

Memory usage change @ c31c2da

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nicla:nicla_vision	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m7	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nicla:nicla_vision	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0
arduino:samd:mkrgsm1400	0	0.0	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0
arduino:samd:mkrwan1300
arduino:samd:mkrwifi1010	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32
esp8266:esp8266:huzzah

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

codecov-commenter · 2022-03-09T15:28:42Z

Codecov Report

Merging #310 (c31c2da) into master (45d5672) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          27       27           
  Lines        1113     1113           
=======================================
  Hits         1056     1056           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d5672...c31c2da. Read the comment docs.

pennam · 2022-03-11T07:45:26Z

👋 @aentinger just to let you know that i've updated the PR and removed all M4 build options from the core and from the CI because at the moment the wifi module is not working on the M4 core.

Do not build OTA functions for PORTENTA_H7_M4

97e6472

per1234 added the topic: code Related to content of the project itself label Mar 9, 2022

aentinger approved these changes Mar 9, 2022

View reviewed changes

pennam added 2 commits March 9, 2022 11:21

Completely remove ARDUINO_PORTENTA_H7_M4 from the code since wifi mod…

21d9117

…ule is not working on the M4

Remove envie_m4 from compile-examples workflow

c31c2da

pennam changed the title ~~PORTENTA_H7_M4: OTA: Do not build portenta_h7_onOTARequest()~~ PORTENTA_H7_M4: Remove M4 core from supported build options Mar 9, 2022

pennam mentioned this pull request Mar 11, 2022

Remove __AVR__ compile options to improve code clarity #311

Merged

pennam merged commit 451d57d into arduino-libraries:master Mar 31, 2022

pennam mentioned this pull request Sep 9, 2022

CI: Use mbed_portenta core release instead of ArduinoCore-mbed HEAD #333

Merged

pennam deleted the portenta_m4_no_ota branch May 17, 2024 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PORTENTA_H7_M4: Remove M4 core from supported build options #310

PORTENTA_H7_M4: Remove M4 core from supported build options #310

pennam commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

aentinger left a comment

github-actions bot commented Mar 9, 2022

codecov-commenter commented Mar 9, 2022

pennam commented Mar 11, 2022

	#if defined(ARDUINO_PORTENTA_H7_M7) \|\| defined(ARDUINO_NICLA_VISION)
	#define OTA_STORAGE_PORTENTA_QSPI (1)
	#else
	#define OTA_STORAGE_PORTENTA_QSPI (0)
	#endif

	#if (OTA_STORAGE_SFU \|\| OTA_STORAGE_SSU \|\| OTA_STORAGE_SNU \|\| OTA_STORAGE_PORTENTA_QSPI) && !defined(ARDUINO_AVR_UNO_WIFI_REV2)
	#define OTA_ENABLED (1)
	#else
	#define OTA_ENABLED (0)
	#endif

PORTENTA_H7_M4: Remove M4 core from supported build options #310

PORTENTA_H7_M4: Remove M4 core from supported build options #310

Conversation

pennam commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

aentinger left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 9, 2022

codecov-commenter commented Mar 9, 2022

Codecov Report

pennam commented Mar 11, 2022