Refresh spell check CI workflow #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
per1234
commented
Jun 4, 2020
per1234
commented
- Fix workflow format
- Fix misspelled word in comment that would cause the check to fail
- Exclude externally maintained resource folder that contains misspelled words
- Add name causing a false positive to the ignore list
- Remove entries from ignore list that are no longer needed now that it's possible to ignore paths containing externally maintained resources
An unintentional extra indent made the YAML not a valid GitHub Actions workflow.
This was causing the spell check CI workflow to fail.
…y-maintained resources A misspelled word in the tinycbor library was causing the spell check CI workflow to fail. Since this code is not maintained in this repository, it is best to just exclude that folder from the misspelled words check.
These entries were previously necessary to ignore misspelled words in the external resources contained in the repository because the spell check action didn't have the ability to exclude those paths. Since then, the "skip-paths" input was added to the action, so these entries only increase the chances of false negatives from the spell check CI workflow.
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 30 30
Lines 976 976
=======================================
Hits 949 949
Misses 27 27
Continue to review full report at Codecov.
|
|
Memory usage change @d9317712f26f32f9be1b5040576a413fdb18c141
|
aentinger
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.