Skip to content

Commit 39c88ab

Browse files
authored
Refresh spell check CI workflow (#134)
* Fix YAML formatting of spell check CI workflow An unintentional extra indent made the YAML not a valid GitHub Actions workflow. * Fix misspelled word in comment This was causing the spell check CI workflow to fail. * Configure spell check CI workflow to ignore name causing a false positive * Configure spell check CI workflow to skip folder containing externally-maintained resources A misspelled word in the tinycbor library was causing the spell check CI workflow to fail. Since this code is not maintained in this repository, it is best to just exclude that folder from the misspelled words check. * Remove unnecessary entries from spell check ignore list These entries were previously necessary to ignore misspelled words in the external resources contained in the repository because the spell check action didn't have the ability to exclude those paths. Since then, the "skip-paths" input was added to the action, so these entries only increase the chances of false negatives from the spell check CI workflow.
1 parent 3ec5904 commit 39c88ab

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

.github/workflows/spell-check.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ jobs:
1414
uses: arduino/actions/libraries/spell-check@master
1515
with:
1616
ignore-words-list: extras/codespell-ignore-words-list.txt
17-
skip-paths: ./extras/test/external
17+
skip-paths: ./extras/test/external,./src/cbor/lib/tinycbor
+1-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
11
wan
2-
nd
3-
atleast
4-
derrived
5-
aline
6-
anid
2+
alocation

src/property/PropertyContainer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void PropertyContainer::begin(GetTimeCallbackFunc func)
4848

4949
Property & PropertyContainer::addPropertyReal(Property & property, String const & name, Permission const permission, int propertyIdentifier)
5050
{
51-
/* Check wether or not the property already has been added to the container */
51+
/* Check whether or not the property already has been added to the container */
5252
Property * p = getProperty(name);
5353
if(p != nullptr) return (*p);
5454

0 commit comments

Comments
 (0)