-
Notifications
You must be signed in to change notification settings - Fork 80
Add GitHub Actions workflow to run unit tests and check code coverage #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good morning 👋 Merging #122 in I created a small conflict on the README. Can you please rebase and resolve? I've also been thinking - as a matter of fact we can merge this now and I just rebase the #118 OTA branch. Another possibility would be to merge this directly into the OTA #118 branch. This has the added benefit of not showing a "broken-build" badge on the README as long as the OTA branch is not merged. What are your thoughts on this? |
I have now done this.
I wouldn't want the broken badge in the readme for a long period of time, but if it's only a short period, then no big deal.
It's fine with me if you want it in that PR. That would cause it to be merged when it's needed. Since #118 is from a branch (rather than a fork as in this PR), I believe it will also allow the Unit Test workflow to run on the PR so you can verify the workflow is working correctly. |
That's great! Can you readjust this PR so it can be merged to https://github.com/arduino-libraries/ArduinoIoTCloud/tree/ota instead of master? |
Memory usage change @72e6cae0022e47a420591fa418e56ad984e062b0
|
I have now changed the base branch to The "Check code coverage" step of the Unit Tests workflow is currently failing because CMakeLists.txt doesn't add the
Would you like me to add those lines to CMakeLists.txt? |
On every pull request or push that changes relevant files: - Run unit tests - Print coverage report to the workflow log - Upload coverage report to Codecov
Yes please 😉 👍 |
On every pull request or push that changes relevant files (anything under
extras/test/
orsrc/
):This PR is dependent on #118. The workflow is currently expected to fail because the unit tests won't be added until #118 is merged.
Demonstration:
https://github.com/per1234/ArduinoIoTCloud/runs/646210541?check_suite_focus=true
https://codecov.io/github/per1234/ArduinoIoTCloud/commit/77fe90bb786f3e0843cb03b2839d1fd58c94995e
Fixes #119