Skip to content

Commit 738178a

Browse files
committed
The OTA out topic is not being used, therefore it can be removed from the implementation
1 parent cfb5a09 commit 738178a

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

src/ArduinoIoTCloudTCP.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ ArduinoIoTCloudTCP::ArduinoIoTCloudTCP():
7777
_dataTopicOut(""),
7878
_dataTopicIn(""),
7979
_ota_topic_in{""},
80-
_ota_topic_out{""},
8180
_ota_logic{nullptr},
8281
_ota_storage_type{static_cast<int>(OTAStorage::Type::NotAvailable)},
8382
_ota_error{static_cast<int>(OTAError::None)}
@@ -138,7 +137,6 @@ int ArduinoIoTCloudTCP::begin(String brokerAddress, uint16_t brokerPort)
138137
_dataTopicOut = getTopic_dataout();
139138
_dataTopicIn = getTopic_datain();
140139
_ota_topic_in = getTopic_ota_in();
141-
_ota_topic_out = getTopic_ota_out();
142140

143141
_thing.begin();
144142
_thing.registerGetTimeCallbackFunc(getTime);

src/ArduinoIoTCloudTCP.h

-2
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
120120
String _dataTopicOut;
121121
String _dataTopicIn;
122122
String _ota_topic_in;
123-
String _ota_topic_out;
124123

125124
OTALogic * _ota_logic;
126125
int _ota_storage_type;
@@ -133,7 +132,6 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
133132
inline String getTopic_dataout () { return ( getThingId().length() == 0) ? String("/a/d/" + getDeviceId() + "/e/o") : String("/a/t/" + getThingId() + "/e/o"); }
134133
inline String getTopic_datain () { return ( getThingId().length() == 0) ? String("/a/d/" + getDeviceId() + "/e/i") : String("/a/t/" + getThingId() + "/e/i"); }
135134
inline String getTopic_ota_in () { return String("/a/d/" + getDeviceId() + "/ota/i"); }
136-
inline String getTopic_ota_out () { return String("/a/d/" + getDeviceId() + "/ota/o"); }
137135

138136
static void onMessage(int length);
139137
void handleMessage(int length);

0 commit comments

Comments
 (0)