-
Notifications
You must be signed in to change notification settings - Fork 612
Add MySql, BigQuery to all dialects #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AugustoFKL , @alamb
in test parse_delimited_identifiers |
@omer-shtivi I'd say to move the test, as MySQL doesn't accept 'x' as an identifier Thanks for adding MySQL and BigQuery to all tests. |
If we want to support parse_similar_to and parse_like in mysql, we need to support getting the an-escaped char. SELECT * FROM customers WHERE name {}LIKE '%a' ESCAPE '\' at mysql needs to be: SELECT * FROM customers WHERE name {}LIKE '%a' ESCAPE '\\' the |
b81ffce
to
a436aa9
Compare
@omer-shtivi I think this can be directed to another issue or PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that LGTM.
@alamb ready for your look :)
This is in essence a little refactor, right @omer-shtivi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry the previous comment, missclick)
I think that LGTM.
@alamb ready for your look :)
This is in essence a little refactor, right @omer-shtivi ?
Hi @AugustoFKL , |
Thank you @omer-shtivi |
Pull Request Test Coverage Report for Build 3388319891
💛 - Coveralls |
close #690