You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is for internal but some fixes may be for users.
In tests/sqlparser_common.rs (⚠️ linked page may freeze your browser), a lot of test cases depend on fn all_dialects() to test all dialects.
But this fn all_dialects() doesn't include MySqlDialect and BigQueryDialect currently.
So we should include those to all_dialects and fix failed test cases after changing.
Change all_dialects to add MySqlDialect and BigQueryDialect (src/test_utils.rs):
failures:
parse_at_timezone
parse_collate
parse_collate_after_parens
parse_delete_statement
parse_delimited_identifiers
parse_like
parse_similar_to
test result: FAILED. 187 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s
error: test failed, to rerun pass '--test sqlparser_common'
The text was updated successfully, but these errors were encountered:
unvalley
changed the title
Fix test util fn all_dialects() to test all dialects actually
Fix testutil fn all_dialects() to test all dialects actually
Oct 26, 2022
unvalley
changed the title
Fix testutil fn all_dialects() to test all dialects actually
Fix test-util fn all_dialects() to test all dialects actually
Oct 26, 2022
Uh oh!
There was an error while loading. Please reload this page.
This is for internal but some fixes may be for users.
In tests/sqlparser_common.rs (⚠️ linked page may freeze your browser), a lot of test cases depend on fn all_dialects() to test all dialects.
But this
fn all_dialects()
doesn't includeMySqlDialect
andBigQueryDialect
currently.So we should include those to
all_dialects
and fix failed test cases after changing.Change all_dialects to add MySqlDialect and BigQueryDialect (src/test_utils.rs):
Test results after changing above:
The text was updated successfully, but these errors were encountered: