Skip to content

Add LIMIT as RESERVED_FOR_TABLE_ALIAS #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2019
Merged

Conversation

ivanceras
Copy link
Contributor

@ivanceras ivanceras commented May 18, 2019

Closes Issue67


This change is Reviewable

@coveralls
Copy link

coveralls commented May 18, 2019

Pull Request Test Coverage Report for Build 180

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.11%

Totals Coverage Status
Change from base Build 176: 0.03%
Covered Lines: 2872
Relevant Lines: 3223

💛 - Coveralls

@nickolay
Copy link
Contributor

Thanks for the PR! It looks good, but unfortunately we didn't get to merging it immediately, and merging it now will cause (trivial) conflicts with #69 and possibly other pending PRs. I am going to merge it after the other PRs land, though it might take a while.

@benesch
Copy link
Contributor

benesch commented May 31, 2019

Actually, since I just rebased #69, I might as well rebase it on top of this PR. Thanks for your contribution, @ivanceras! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELECT query with LIMIT clause but no WHERE clause fails to parse.
4 participants