Support HAVING/LIMIT/OFFSET/FETCH without FROM and other follow-ups #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres allows it, as does ANSI SQL per the <query expression> definition: https://jakewheat.github.io/sql-overview/sql-2011-foundation-grammar.html#_7_13_query_expression
...which is weird but allowed: https://jakewheat.github.io/sql-overview/sql-2011-foundation-grammar.html#table-expression https://dba.stackexchange.com/a/57453/15599 Also add a test for GROUP BY .. HAVING
Pull Request Test Coverage Report for Build 352
💛 - Coveralls |
Pull Request Test Coverage Report for Build 351
💛 - Coveralls |
benesch
approved these changes
Jun 16, 2019
src/dialect/keywords.rs
Outdated
| ]; | ||
|
|
||
| /// Can't be used as a column alias, so that `SELECT <expr> alias` | ||
| /// can be parsed unambiguously without looking ahead. | ||
| pub const RESERVED_FOR_COLUMN_ALIAS: &[&str] = &[ | ||
| // Reserved as both a table and a column alias: | ||
| WITH, SELECT, WHERE, GROUP, ORDER, UNION, EXCEPT, INTERSECT, | ||
| WITH, SELECT, WHERE, GROUP, ORDER, LIMIT, OFFSET, FETCH, UNION, EXCEPT, INTERSECT, |
There was a problem hiding this comment.
I know this isn't the fault of this commit, but it's a shame that these keywords have to be duplicated between the two constants. I don't have any obvious solutions, and definitely doesn't need to be considered in this PR; just thought I'd flag it in case you happened to have any ideas.
There was a problem hiding this comment.
I don't like it either, but the solutions seemed too complex for a trivial problem...
These lists will become dialect-specific at some point, and we would be able to build the reserved lists in the dialect constructor then, I guess.
benesch
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68 made me review the keywords in
RESERVED_FOR_TABLE_ALIASandRESERVED_FOR_COLUMN_ALIAS, and I realized more of them need to be "Reserved as both a table and a column alias".Also after
TableAliaswas introduced in #98 to representalias [ (col1, col2, ...) ]as part of a TableFactor, it makes sense to re-use it inCte.