Skip to content

Support no_std #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Support no_std #332

merged 2 commits into from
Aug 21, 2021

Conversation

koushiro
Copy link
Member

@koushiro koushiro commented Aug 20, 2021

  • Add std feature and default feature
  • Support no_std
  • Update CI for no_std check

Close #286
Close #327

Signed-off-by: koushiro [email protected]

Signed-off-by: koushiro <[email protected]>
Signed-off-by: koushiro <[email protected]>
@coveralls
Copy link

coveralls commented Aug 20, 2021

Pull Request Test Coverage Report for Build 1149867009

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.107%

Totals Coverage Status
Change from base Build 1149764896: 0.0%
Covered Lines: 5492
Relevant Lines: 6095

💛 - Coveralls

@koushiro
Copy link
Member Author

@Dandandan PTAL

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @koushiro !

I reviewed the code and the output of the new CI check https://github.com/sqlparser-rs/sqlparser-rs/pull/332/checks?check_run_id=3379689095 and it looks good to me

cc @Dandandan let me know if you have any issues with merging this PR

@@ -13,12 +13,15 @@ include = [
"Cargo.toml",
]
edition = "2018"
resolver = "2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change to resolver v2 needed for this change, or is it a nice to have / drive by cleanup?

reference https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it was added to pass CI 'compile-no-std' check

Because the dev-dependency 'simple_logger' introduces the std feature of log, if resolver=2 is not used, libstd will be implicitly introduced in the CI 'compile-no-std'

@Dandandan Dandandan merged commit 5bc109a into apache:main Aug 21, 2021
@koushiro koushiro deleted the support-no-std branch August 21, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants