Skip to content

Add support for no_std + alloc #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

joshwd36
Copy link
Contributor

@joshwd36 joshwd36 commented Jan 2, 2021

I'm looking to use this in a no_std + alloc environment and so it would be really helpful to allow that. I've implemented this by having a std feature that is enabled by default, so it shouldn't affect existing users. The only thing the library uses that isn't available in core or alloc is the error trait, and a few println!s in tests.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 457813297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 92.178%

Files with Coverage Reduction New Missed Lines %
src/parser.rs 7 88.39%
Totals Coverage Status
Change from base Build 449512338: 0.8%
Covered Lines: 4855
Relevant Lines: 5267

💛 - Coveralls

@joshwd36
Copy link
Contributor Author

joshwd36 commented Jan 2, 2021

The failed clippy lints seem to be elsewhere in the code, so I'll fix them in a separate PR.

@Dandandan
Copy link
Contributor

Interesting @joshwd36 ! Will try to look at this soon. I am curious what you are planning to use it for :)

@joshwd36
Copy link
Contributor Author

joshwd36 commented Jan 7, 2021

I am curious what you are planning to use it for :)

I'm hoping to write a basic database engine for a unikernel OS, that doesn't have std (yet, although I may work on that), but is still functional, and wouldn't be used on the low-power devices that would normally be associated with no_std, but on hypervisors on a server.

@yjhmelody
Copy link

Is this PR still going on? Supporting no-std is great

@koushiro koushiro mentioned this pull request Aug 20, 2021
@alamb
Copy link
Contributor

alamb commented Aug 20, 2021

As noted by @koushiro, this PR is likely superceded by #332

@joshwd36
Copy link
Contributor Author

As noted by @koushiro, this PR is likely superceded by #332

That's fine. Should I close this now or wait for #332 to be merged?

@alamb
Copy link
Contributor

alamb commented Aug 20, 2021

Let's leave it open and I think when we merge #332 the Github API will close this one too

@joshwd36 joshwd36 deleted the no_std branch August 26, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants