-
Notifications
You must be signed in to change notification settings - Fork 602
SET with a list of comma separated assignments #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you. The only thing missing I can think of is the per-variable scope support represented by #1694, which should be a separate PR IMO. However, it will require changes to this new variant (and probably moving the modifier
parsing around, not sure exactly how), so it would be good to keep in mind while reviewing this.
Ended up being a big one. API changes:
Other: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohamedAbdeen21! The changes look reasonable to me overall, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @MohamedAbdeen21!
Also thanks for the reviews @mvzink!
cc @alamb
Closes #1694
parse_set
parser (using match, extracting functions, etc ..)SET a = 1, b = 2, ...
) and a new variant to represent the syntax