-
Notifications
You must be signed in to change notification settings - Fork 602
Better representation for MySQL list of variable assignments #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was referenced Feb 4, 2025
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Feb 26, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further requires [sqlparser#1697] getting fixed. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Feb 26, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Feb 26, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Feb 28, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Feb 28, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Mar 5, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Mar 5, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Mar 5, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Mar 5, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this issue
Mar 5, 2025
This was caught by logictests and some framework tests. Several framework tests hit one of these conditions, but I don't believe we'll inspect such statements anyway. If we do, we'll improve this conversion at a later date. Likely, improving this further will require fixing [sqlparser#1697]. [sqlparser#1697]: apache/datafusion-sqlparser-rs#1697 Change-Id: I2ddfc73a8b6d86d4aec8b4d4fefab86511a01b48 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8910 Tested-by: Buildkite CI Reviewed-by: Marcelo Altmann <[email protected]>
Closed by #1757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sqlparser currently accepts Postgres-style
set variable = expr
and Snowflake-styleset (variable, other_variable) = (expr, expr)
syntax. It also accepts MySQL-styleset variable = expr, other_variable = expr
syntax, but not in the way one might expect:other_variable = expr
becomes another expression in the list of values.This round-trips okay, and could be sufficient for many use cases if they are willing to decipher the binary operators in the expressions. However, it might be appropriate to represent this differently in the AST, along the lines of:
This could be a bit annoying to parse unless we simply switch on the dialect at the very start of
parse_set
(MySQL doesn't support either Postgres- or Snowflake-style assignments).The text was updated successfully, but these errors were encountered: