Add support of COMMENT ON syntax for Snowflake #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
force-pushed
the
feature/comment-on-for-snowflake
branch
from
e079d08 to
ee32ab2
Compare
|
cc @iffyio |
|
It looks like there are some conflicts in this PR that need to be resolved before we can merge it |
|
@alamb thanks for your review, |
git-hulk
force-pushed
the
feature/comment-on-for-snowflake
branch
from
ee32ab2 to
9f4a772
Compare
The COMMENT ON syntax has been supported in PostgreSQL. This PR only moves it into the common and adds `supports_comment_on` to enable this feature. Also, this PR extends `SCHEMA`, `DATABASE`, `USER`, `ROLE` as its allowed object type. This closes apache#1511.
git-hulk
force-pushed
the
feature/comment-on-for-snowflake
branch
from
9f4a772 to
63a7a6f
Compare
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COMMENT ON syntax has been supported in PostgreSQL. This PR only moves it into the common and adds
supports_comment_onto enable this feature. Also, this PR extendsSCHEMA,DATABASE,USER,ROLEas its allowed object type.This closes #1511.