Skip to content

Snowflake COMMENT ON support #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
psukys opened this issue Nov 11, 2024 · 2 comments · Fixed by #1516
Closed

Snowflake COMMENT ON support #1511

psukys opened this issue Nov 11, 2024 · 2 comments · Fixed by #1516

Comments

@psukys
Copy link

psukys commented Nov 11, 2024

Support for https://docs.snowflake.com/en/sql-reference/sql/comment, for example:

COMMENT ON my_schema.my_table IS 'hello world'

Currently, parsing fails:

Expected: an SQL statement, found: COMMENT
@git-hulk
Copy link
Member

git-hulk commented Nov 11, 2024 •
edited
Loading

Hi @psukys

I can submit a PR to resolve this issue if you're not planning to do it.

@psukys
Copy link
Author

psukys commented Nov 11, 2024

@git-hulk please do, I lack knowledge on internals to pick it up immediatelly

git-hulk added a commit to git-hulk/sqlparser-rs that referenced this issue Nov 11, 2024
@git-hulk
Add support of COMMENT ON syntax for Snowflake
e079d08 
The COMMENT ON syntax has been supported in PostgreSQL. This PR only
moves it into the common and adds `supports_comment_on` to enable this
feature. Also, this PR extends `SCHEMA`, `DATABASE`, `USER`, `ROLE` as
its allowed object type.

This closes apache#1511.
@git-hulk git-hulk mentioned this issue Nov 11, 2024
Merged
git-hulk added a commit to git-hulk/sqlparser-rs that referenced this issue Nov 11, 2024
@git-hulk
Add support of COMMENT ON syntax for Snowflake
ee32ab2 
The COMMENT ON syntax has been supported in PostgreSQL. This PR only
moves it into the common and adds `supports_comment_on` to enable this
feature. Also, this PR extends `SCHEMA`, `DATABASE`, `USER`, `ROLE` as
its allowed object type.

This closes apache#1511.
git-hulk added a commit to git-hulk/sqlparser-rs that referenced this issue Nov 13, 2024
@git-hulk
Add support of COMMENT ON syntax for Snowflake
9f4a772 
The COMMENT ON syntax has been supported in PostgreSQL. This PR only
moves it into the common and adds `supports_comment_on` to enable this
feature. Also, this PR extends `SCHEMA`, `DATABASE`, `USER`, `ROLE` as
its allowed object type.

This closes apache#1511.
git-hulk added a commit to git-hulk/sqlparser-rs that referenced this issue Nov 13, 2024
@git-hulk
Add support of COMMENT ON syntax for Snowflake
63a7a6f 
The COMMENT ON syntax has been supported in PostgreSQL. This PR only
moves it into the common and adds `supports_comment_on` to enable this
feature. Also, this PR extends `SCHEMA`, `DATABASE`, `USER`, `ROLE` as
its allowed object type.

This closes apache#1511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support of COMMENT ON syntax for Snowflake git-hulk/sqlparser-rs
2 participants
@psukys @git-hulk