fix: Fix stack overflow in parse_subexpr #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the guard from parse_expr to parse_subexpr. This helps prevent us from overflowing the stack. Also added a test case for one such example where and expression contains a repeated +(unary plus) leading to a stackoverflow.
Pull Request Test Coverage Report for Build 10715369940Details
💛 - Coveralls |
alamb
approved these changes
Sep 6, 2024
|
FYI @iffyio |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the guard from parse_expr to parse_subexpr. This helps
prevent us from overflowing the stack in more cases. Also added a test case for where the current code has a stackoverflow. The test cases is a expression contains a repeated +(unary plus) leading to a stackoverflow.
Found by running the fuzzer.