fix: Fix stack overflow in parse_subexpr (apache#1410)

Author: eejbyfeldt

src/parser/mod.rs

@@ -897,12 +897,12 @@ impl<'a> Parser<'a> {
 
     /// Parse a new expression.
     pub fn parse_expr(&mut self) -> Result<Expr, ParserError> {
-        let _guard = self.recursion_counter.try_decrease()?;
         self.parse_subexpr(self.dialect.prec_unknown())
     }
 
     /// Parse tokens until the precedence changes.
     pub fn parse_subexpr(&mut self, precedence: u8) -> Result<Expr, ParserError> {
+        let _guard = self.recursion_counter.try_decrease()?;
         debug!("parsing expr");
         let mut expr = self.parse_prefix()?;
         debug!("prefix: {:?}", expr);

tests/sqlparser_common.rs

@@ -8982,6 +8982,13 @@ fn parse_deeply_nested_parens_hits_recursion_limits() {
     assert_eq!(ParserError::RecursionLimitExceeded, res.unwrap_err());
 }
 
+#[test]
+fn parse_deeply_nested_unary_op_hits_recursion_limits() {
+    let sql = format!("SELECT {}", "+".repeat(1000));
+    let res = parse_sql_statements(&sql);
+    assert_eq!(ParserError::RecursionLimitExceeded, res.unwrap_err());
+}
+
 #[test]
 fn parse_deeply_nested_expr_hits_recursion_limits() {
     let dialect = GenericDialect {};