fix: only require DESCRIBE TABLE for Snowflake and ClickHouse dialect
#1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 15, 2024
| Some(Keyword::FORMATTED) => hive_format = Some(HiveDescribeFormat::Formatted), | ||
| _ => {} | ||
| } | ||
| let hive_format = |
There was a problem hiding this comment.
this was a drive by cleanup to avoid using mut
alamb
commented
Aug 15, 2024
| _ => None, | ||
| }; | ||
|
|
||
| let has_table_keyword = if self.dialect.describe_requires_table_keyword() { |
There was a problem hiding this comment.
this is the actual fix, and the rest of the PR is test updated / documentation
alamb
force-pushed
the
alamb/fix_describe
branch
from
bf56eae to
6ef20b0
Compare
Pull Request Test Coverage Report for Build 10411444248Details
💛 - Coveralls |
5 tasks
git-hulk
approved these changes
Aug 16, 2024
|
@alamb Thanks for your fix, as well as thanks for @samuelcolvin finding this regression. |
|
Thanks for the reviews @samuelcolvin @iffyio and @git-hulk -- let's ship this release! 🚀 |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
Rationale
@git-hulk added support for
DESCRIBE TABLE <..>syntax for ClickHouse and Snowflake in #1351Unfrtunately, this seems to have caused a regression in
describe table(aka describing a table namedtablewhich apparently we do in the DataFusion tests) which we did not have test coverage forChanges
DESCRIBE TABLEkeyword for ClickHouse and Snowflake dialects