Allow to use the TABLE keyword in DESC|DESCRIBE|EXPLAIN TABLE statement #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
commented
Jul 24, 2024
| @@ -7972,10 +7972,13 @@ impl<'a> Parser<'a> { | |||
| _ => {} | |||
| } | |||
|
|
|||
| // only allow to use TABLE keyword for DESC|DESCRIBE statement | |||
| let has_table_keyword = self.parse_keyword(Keyword::TABLE); | |||
There was a problem hiding this comment.
I didn't add the dialect guard since the TABLE keyword is allowed in multiple dialects(Snowflake and ClicHouse), and it should be good to let the downstream determine if it's a valid syntax.
Pull Request Test Coverage Report for Build 10070975254Details
💛 - Coveralls |
iffyio
approved these changes
Jul 24, 2024
|
@samuelcolvin found a seeming regression due to this change here: #1385 |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1160.