Skip to content

Update version of GitHub Actions #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Update version of GitHub Actions #1363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
uses: hecrj/setup-rust-action@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little worried about this action as it doesn't look very actively maintained

https://github.com/hecrj/setup-rust-action/issues

However, this is probably ok -- maybe we can find time to setup rust ourselves (using rustup install)

Here is how we do it in DataFusion: https://github.com/apache/datafusion/blob/main/.github/actions/setup-builder/action.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb Thanks for your review and comment. I will be happy to do this when I get time.

with:
components: rustfmt
# Note that `nightly` is required for `license_template_path`, as
# it's an unstable feature.
rust-version: nightly
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- run: cargo +nightly fmt -- --check --config-path <(echo 'license_template_path = "HEADER"')

lint:
runs-on: ubuntu-latest
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
uses: hecrj/setup-rust-action@v2
with:
components: clippy
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- run: cargo clippy --all-targets --all-features -- -D warnings

compile:
runs-on: ubuntu-latest
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
- uses: actions/checkout@master
uses: hecrj/setup-rust-action@v2
- uses: actions/checkout@v4
- run: cargo check --all-targets --all-features

docs:
Expand All @@ -41,18 +41,18 @@ jobs:
RUSTDOCFLAGS: "-Dwarnings"
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
- uses: actions/checkout@master
uses: hecrj/setup-rust-action@v2
- uses: actions/checkout@v4
- run: cargo doc --document-private-items --no-deps --workspace --all-features

compile-no-std:
runs-on: ubuntu-latest
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
uses: hecrj/setup-rust-action@v2
with:
targets: 'thumbv6m-none-eabi'
- uses: actions/checkout@master
- uses: actions/checkout@v4
- run: cargo check --no-default-features --target thumbv6m-none-eabi

test:
Expand All @@ -62,7 +62,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Setup Rust
uses: hecrj/setup-rust-action@v1
uses: hecrj/setup-rust-action@v2
with:
rust-version: ${{ matrix.rust }}
- name: Install Tarpaulin
Expand All @@ -72,15 +72,15 @@ jobs:
version: 0.14.2
use-tool-cache: true
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Test
run: cargo test --all-features

test-coverage:
runs-on: ubuntu-latest
steps:
- name: Setup Rust
uses: hecrj/setup-rust-action@v1
uses: hecrj/setup-rust-action@v2
with:
rust-version: stable
- name: Install Tarpaulin
Expand All @@ -90,7 +90,7 @@ jobs:
version: 0.14.2
use-tool-cache: true
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Coverage
run: cargo tarpaulin -o Lcov --output-dir ./coverage
- name: Coveralls
Expand All @@ -104,8 +104,8 @@ jobs:
needs: [test]
steps:
- name: Set up Rust
uses: hecrj/setup-rust-action@v1
- uses: actions/checkout@v2
uses: hecrj/setup-rust-action@v2
- uses: actions/checkout@v4
- name: Publish
shell: bash
run: |
Expand Down
Loading