Update version of GitHub Actions #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the version of the following actions: - hecrj/setup-rust-action from v1 to v2 - actions/checkout from v2 to v4
Pull Request Test Coverage Report for Build 10248179403Details
💛 - Coveralls |
iffyio
approved these changes
Aug 7, 2024
alamb
approved these changes
Aug 7, 2024
| @@ -8,31 +8,31 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Set up Rust | |||
| uses: hecrj/setup-rust-action@v1 | |||
| uses: hecrj/setup-rust-action@v2 | |||
There was a problem hiding this comment.
I am a little worried about this action as it doesn't look very actively maintained
https://github.com/hecrj/setup-rust-action/issues
However, this is probably ok -- maybe we can find time to setup rust ourselves (using rustup install)
Here is how we do it in DataFusion: https://github.com/apache/datafusion/blob/main/.github/actions/setup-builder/action.yaml
There was a problem hiding this comment.
@alamb Thanks for your review and comment. I will be happy to do this when I get time.
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of the following actions: