Skip to content

Update comments after the renaming done in PR #105 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

nickolay
Copy link
Contributor

@nickolay nickolay commented Jul 1, 2019

No description provided.

@nickolay nickolay requested a review from benesch July 1, 2019 01:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 393

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.239%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/test_utils.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 386: 0.0%
Covered Lines: 4326
Relevant Lines: 4690

💛 - Coveralls

Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks!

@nickolay nickolay merged commit b653859 into apache:master Jul 1, 2019
@nickolay nickolay deleted the pr/renames-comments branch July 1, 2019 01:56
@nickolay
Copy link
Contributor Author

nickolay commented Jul 1, 2019

@benesch that was fast! Thanks.

@benesch
Copy link
Contributor

benesch commented Jul 1, 2019

Lucky coincidence! I just happened to be in the process of reviewing #124 so I was primed to see your PR come through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants