Skip to content

implement fmt::Display instead of ToString #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

vemoo
Copy link
Contributor

@vemoo vemoo commented Jun 30, 2019

As mentioned in the documentation for ToString implementing Display should be prefered.

This should be faster and use less memory because no intermediate Strings are created.

@coveralls
Copy link

coveralls commented Jun 30, 2019

Pull Request Test Coverage Report for Build 392

  • 398 of 453 (87.86%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.549%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/ddl.rs 36 39 92.31%
src/ast/operator.rs 23 26 88.46%
src/ast/data_type.rs 21 31 67.74%
src/ast/mod.rs 160 179 89.39%
src/tokenizer.rs 21 41 51.22%
Totals Coverage Status
Change from base Build 386: 0.3%
Covered Lines: 4335
Relevant Lines: 4684

💛 - Coveralls

Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! I've wanted to do this for a while.

I want to see if @nickolay has any thoughts before merging, though.

@nickolay
Copy link
Contributor

nickolay commented Jul 1, 2019

if @nickolay has any thoughts

Nope - if you think this is right, let's land it!

@benesch benesch merged commit ed76cd6 into apache:master Jul 1, 2019
nickolay added a commit to nickolay/sqlparser-rs that referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants