Accept WINDOW clause after QUALIFY when parsing #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigQuery requires that WINDOW clauses come after QUALIFY which the parser currently does not support. This updates the parser to accept the clauses in either order.
Pull Request Test Coverage Report for Build 8942947164Details
💛 - Coveralls |
JichaoS
pushed a commit
to luabase/sqlparser-rs
that referenced
this pull request
May 7, 2024
Co-authored-by: ifeanyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1218 from @iffyio which needed to have conflicts resolved.
I merged up to main, and fixed conflicts, but I don't have permissions push directly to the upstream branch https://github.com/validio-io/sqlparser-rs/tree/window-qualify-ordering so I made a new one
Closes #1218
Description from that PR: