Accept WINDOW clause after QUALIFY when parsing #1218
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positioning of QUALIFY and WINDOW clauses differ between dialects.
BigQuery requires that WINDOW clauses come after QUALIFY which fails on the parser as a result.
This updates the parser to accept the clauses in either order.
It's also possible to flag this behavior on the dialect level so that we don't parse one for the other (didn't opt for that in this case because it felt like a minor detail but probably make more sense), let me know if that's preferred!Actually found some dialects like databricks can accept either order so probably makes sense to have the parser accept in any order