Skip to content

Doc improvements and follow-ups to the recent PRs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 14, 2019
Merged

Doc improvements and follow-ups to the recent PRs #115

merged 9 commits into from
Jun 14, 2019

Conversation

nickolay
Copy link
Contributor

See individual commits.

@nickolay nickolay requested a review from benesch June 13, 2019 01:33
@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 347

  • 39 of 41 (95.12%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 92.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sqlparser.rs 32 34 94.12%
Files with Coverage Reduction New Missed Lines %
src/sqlparser.rs 1 93.64%
Totals Coverage Status
Change from base Build 342: 0.3%
Covered Lines: 4260
Relevant Lines: 4621
💛 - Coveralls

nickolay added 3 commits June 13, 2019 11:11
@nickolay
Remove unused parse_literal_double
f18fbe5 
`parse_value` handles parsing a non-integer value in expression context,
and we use parse_literal_uint() when expecting a number in other 
contexts (such as `FETCH FIRST ... ROWS`)
@nickolay
Use self.expected() more
45c9aa1
@nickolay
Add a test for parsing the NULL literal
5c7ff79 
(Coveralls notices we didn't have one.)
benesch
benesch approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. This looks great! Thanks for catching the dead file I accidentally added 🤦‍♂.

@nickolay nickolay merged commit dc26c4a into apache:master Jun 14, 2019
@nickolay nickolay deleted the pr/followups branch June 14, 2019 22:57
@nickolay
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickolay @coveralls @benesch