Skip to content

Standardize license headers #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Standardize license headers #79

merged 1 commit into from
Jun 11, 2019

Conversation

benesch
Copy link
Contributor

@benesch benesch commented May 22, 2019

Standardize the license header, removing the Grove Enterprise copyright
notice where it exists per #58. Also add a CI check to ensure that files
without license headers don't get merged.

Fix #58.

@andygrove it'd be good to get your eyes on this, because I'm removing your copyright notice (based on what you said in #58) and I'm not sure if I should add something else in its place.

@benesch benesch force-pushed the license branch 2 times, most recently from 5d8e8d3 to e29dfeb Compare May 22, 2019 20:19
@coveralls
Copy link

coveralls commented May 22, 2019

Pull Request Test Coverage Report for Build 292

  • 0 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 0 1 0.0%
tests/sqlparser_mssql.rs 0 1 0.0%
tests/sqlparser_postgres.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 287: 0.0%
Covered Lines: 3748
Relevant Lines: 4097

💛 - Coveralls

Standardize the license header, removing the Grove Enterprise copyright
notice where it exists per apache#58. Also add a CI check to ensure that files
without license headers don't get merged.

Fix apache#58.
@andygrove
Copy link
Member

Thanks @benesch I approve of removing the Grove Enterprises mentions

@andygrove andygrove merged commit b379480 into apache:master Jun 11, 2019
nickolay added a commit to nickolay/sqlparser-rs that referenced this pull request Jun 13, 2019
@benesch benesch deleted the license branch June 21, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove copyright from headers
3 participants