fix(typescript): use correct ts version and fix promise types #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Sep 15, 2016
| @@ -44,6 +44,7 @@ | |||
| "devDependencies": { | |||
| "@angular/compiler-cli": "^0.5.0", | |||
| "@angular/platform-server": "^2.0.0-rc.5", | |||
| "@types/es6-promise": "0.0.31", | |||
There was a problem hiding this comment.
this is bad, why can't you change the other side to use lib.es2015.promise.d.ts instead?
davideast
reviewed
Sep 15, 2016
| @@ -69,7 +70,7 @@ | |||
| "traceur": "0.0.96", | |||
| "tsd": "^0.6.5", | |||
| "typedoc": "github:jeffbcross/typedoc", | |||
| "typescript": "next", | |||
| "typescript": "^1.9.0-dev.20160627-1.0", | |||
There was a problem hiding this comment.
Firebase requires 2.0+.
Angular's compiler CLI requires typescript@^1.9.0-dev. The built-in Promise typings for that version of TS don't play well with Firebase Promise when using Promise.resolve, so the firebase_sdk_auth_backend has a function that will cast the promises as the correct type.
jeffbcross
force-pushed
the
fix-ts-promise
branch
from
33322c6 to
4750f45
Compare
robwormald
reviewed
Sep 15, 2016
| @@ -1,24 +1,24 @@ | |||
| import { Observable } from 'rxjs/Observable'; | |||
| import { ScalarObservable } from 'rxjs/observable/ScalarObservable'; | |||
| import 'rxjs/add/observable/of'; | |||
There was a problem hiding this comment.
can you use the non-sideeffecty version instead?
robwormald
reviewed
Sep 15, 2016
| OrderBySelection, | ||
| LimitToOptions, | ||
| LimitToSelection, | ||
| Primitive | ||
| } from '../interfaces'; | ||
| import 'rxjs/add/operator/merge'; |
There was a problem hiding this comment.
ditto here - import {merge} from 'rxjs/operator/merge' , merge.call()
|
I'll ditch the side-effect operators and observables. |
This change introduces a UMD bundle to the published package, and adds ES2015 modules to the root of the project. Some changes were necessary to fix imports and make rollup work correctly. This change should make AngularFire2 ahead-of-time-compilation -friendly.
Also removed side-effects from tests to verify that code under test wouldn't accidentally rely on a patched operator.
jeffbcross
force-pushed
the
fix-ts-promise
branch
from
db7bdfc to
7921f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.