-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(firestore): Support Firestore Collection Group Queries #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2df0da9
chore(): Remove timing out app deletes
jamesdaniels 8b96c44
chore(): Bump Firebase to allow 6.0
jamesdaniels 80a7cf5
Wat
jamesdaniels c52a397
More
jamesdaniels 3a45ea9
error
jamesdaniels f57d6f7
Yarnin
jamesdaniels 643dcac
Merge branch 'master' into collection_group
jamesdaniels 1b954ba
Fixing tests for AngularFirestoreCollectionGroup
jamesdaniels ff7bb12
Merge branch 'master' into collection_group
jamesdaniels 9f04d58
Updating Firestore querying docs with a mention of CGQ
jamesdaniels 98737e2
Merge branch 'master' into collection_group
jamesdaniels 8dcf5e3
Clarifying the difference between AFSCG and AFSC
jamesdaniels cfdfc53
Merge branch 'master' into collection_group
jamesdaniels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this a bit tough to interpret on the first pass.
Maybe something like "... similar to
AngularFirestoreCollection
. The main difference is thatAngularFirestoreCollectionGroup
has no data operation methods such asadd
because it doesn't have a unique(?concrete?) reference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like concrete.