This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/*): fix typos and links #9800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some typos and link-errors introduced in angular@d1ccf17. Related to angular#9786
| @@ -93,7 +93,7 @@ Moreover, additional dependencies are made available to Controllers: | |||
| * {@link scope `$scope`}: Controllers are associated with an element in the DOM and so are | |||
| provided with access to the {@link scope scope}. Other components (like services) only have | |||
| access to the {@link $rootScope `$rootScope`} service. | |||
| * {@link `$route`} resolves: If a controller is instantiated as part of a route, then any values that | |||
| * {@link api/ngRoute/provider/$routeProvider#when resolves}: If a controller is instantiated as part of a route, then any values that | |||
There was a problem hiding this comment.
ngRoute.$routeProvider#when --- I don't know if the link is super clear here, though, you kinda have to dig through it to get what it's talking about. Also, line length
There was a problem hiding this comment.
@caitp: Ooops, this was a last minute fix and I didn't think about the line length.
The link is indeed kind of weird, but it's the closest I could get to the resolve property (and it's definitely better than a broken link).
If you think we should create an anchor at resolve and target that specifically, just let me know :)
|
fixed up a tiny bit and landed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some typos and link-errors introduced in d1ccf17.
Related to #9786