Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(form.FormController): add 'date' token to FormController $error property #9743

Closed
wants to merge 2 commits into from
Closed

docs(form.FormController): add 'date' token to FormController $error property #9743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d034a7c
docs(form.FormController): add 'date' token to FormController $error …
Oct 22, 2014
e11d101
fixup! docs(form.FormController): add 'date' token to FormController …
Oct 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ng/directive/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ function nullFormRenameControl(control, name) {
* - `pattern`
* - `required`
* - `url`
* - `date`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also add the other ones? datetimelocal, time, week, month

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I even didn't know they exist. I just face a usecase where the token is date so I proposed to add it in the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to add it to the docs, but you should add the other ones too :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a fixup just for you ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's rebase this one now you have read it ;-)

EDIT: Oh! you did it for me, so nice! thx

* - `datetimelocal`
* - `time`
* - `week`
* - `month`
*
* @description
* `FormController` keeps track of all its controls and nested forms as well as the state of them,
Expand Down