This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(form.FormController): add 'date' token to FormController $error property #9743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,7 @@ function nullFormRenameControl(control, name) { | |||
| * - `pattern` | |||
| * - `required` | |||
| * - `url` | |||
| * - `date` | |||
There was a problem hiding this comment.
Why not also add the other ones? datetimelocal, time, week, month
There was a problem hiding this comment.
I even didn't know they exist. I just face a usecase where the token is date so I proposed to add it in the doc.
There was a problem hiding this comment.
I'm happy to add it to the docs, but you should add the other ones too :p
There was a problem hiding this comment.
I added a fixup just for you ;)
There was a problem hiding this comment.
ok let's rebase this one now you have read it ;-)
EDIT: Oh! you did it for me, so nice! thx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi from #ngEurope