Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Adds titles to various links in docs and src for improved accessibility. #7932

Closed
wants to merge 1 commit into from
Closed

Adds titles to various links in docs and src for improved accessibility. #7932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/app/assets/Error404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ <h1>Oops!</h1>

<dl ng-repeat="(key, value) in results" ng-show="value.length" style="float: left; margin-right:20px">
<dt>{{ key }}</dt>
<dd ng-repeat="item in value"><a ng-href="{{ item.path }}">{{ item.name }}</a></dd>
<dd ng-repeat="item in value"><a ng-href="{{ item.path }}" title="{{ item.name }}">{{ item.name }}</a></dd>
</dl>
</div>
2 changes: 1 addition & 1 deletion docs/app/assets/js/angular-bootstrap/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ directive.syntax = function() {
restrict: 'A',
link: function(scope, element, attrs) {
function makeLink(type, text, link, icon) {
return '<a href="' + link + '" class="btn syntax-' + type + '" target="_blank" rel="nofollow">' +
return '<a href="' + link + '" class="btn syntax-' + type + '" target="_blank" rel="nofollow" title="' + text + '">' +
'<span class="' + icon + '"></span> ' + text +
'</a>';
};
Expand Down
14 changes: 7 additions & 7 deletions docs/app/src/tutorials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ angular.module('tutorials', [])
element.addClass('btn-group');
element.addClass('tutorial-nav');
element.append(templateMerge(
'<a href="tutorial/{{prev}}"><li class="btn btn-primary"><i class="glyphicon glyphicon-step-backward"></i> Previous</li></a>\n' +
'<a href="http://angular.github.io/angular-phonecat/step-{{seq}}/app"><li class="btn btn-primary"><i class="glyphicon glyphicon-play"></i> Live Demo</li></a>\n' +
'<a href="https://github.com/angular/angular-phonecat/compare/step-{{diffLo}}...step-{{diffHi}}"><li class="btn btn-primary"><i class="glyphicon glyphicon-search"></i> Code Diff</li></a>\n' +
'<a href="tutorial/{{next}}"><li class="btn btn-primary">Next <i class="glyphicon glyphicon-step-forward"></i></li></a>', props));
'<a href="tutorial/{{prev}}" title="Previous"><li class="btn btn-primary"><i class="glyphicon glyphicon-step-backward"></i> Previous</li></a>\n' +
'<a href="http://angular.github.io/angular-phonecat/step-{{seq}}/app" title="Live Demo"><li class="btn btn-primary"><i class="glyphicon glyphicon-play"></i> Live Demo</li></a>\n' +
'<a href="https://github.com/angular/angular-phonecat/compare/step-{{diffLo}}...step-{{diffHi}}" title="Code Diff"><li class="btn btn-primary"><i class="glyphicon glyphicon-search"></i> Code Diff</li></a>\n' +
'<a href="tutorial/{{next}}" title="Next"><li class="btn btn-primary">Next <i class="glyphicon glyphicon-step-forward"></i></li></a>', props));
}
};
})
Expand All @@ -36,15 +36,15 @@ angular.module('tutorials', [])
'step': '@docTutorialReset'
},
template:
'<p><a href="" ng-click="show=!show;$event.stopPropagation()">Workspace Reset Instructions ➤</a></p>\n' +
'<p><a href="" ng-click="show=!show;$event.stopPropagation()" title="Workspace Reset Instructions ➤">Workspace Reset Instructions ➤</a></p>\n' +
'<div class="alert alert-info" ng-show="show">\n' +
' <p>Reset the workspace to step {{step}}.</p>' +
' <p><pre>git checkout -f step-{{step}}</pre></p>\n' +
' <p>Refresh your browser or check out this step online: '+
'<a href="http://angular.github.io/angular-phonecat/step-{{step}}/app">Step {{step}} Live Demo</a>.</p>\n' +
'<a href="http://angular.github.io/angular-phonecat/step-{{step}}/app" title="Step {{step}} Live Demo">Step {{step}} Live Demo</a>.</p>\n' +
'</div>\n' +
'<p>The most important changes are listed below. You can see the full diff on ' +
'<a ng-href="https://github.com/angular/angular-phonecat/compare/step-{{step ? (step - 1): \'0~1\'}}...step-{{step}}">GitHub</a>\n' +
'<a ng-href="https://github.com/angular/angular-phonecat/compare/step-{{step ? (step - 1): \'0~1\'}}...step-{{step}}" title="See diff on Github">GitHub</a>\n' +
'</p>'
};
});
4 changes: 2 additions & 2 deletions docs/config/templates/errorNamespace.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ <h1>{$ doc.name $}</h1>
</tr>
{% for errorDoc in doc.errors -%}
<tr>
<td><a href="{$ errorDoc.path $}">{$ errorDoc.name $}</td>
<td><a href="{$ errorDoc.path $}" title="{$ errorDoc.name $}">{$ errorDoc.name $}</a></td>
<td>{$ errorDoc.fullName $}</td>
</tr>
{% endfor %}
</table>
</div>
</div>

{% endblock %}
{% endblock %}
58 changes: 29 additions & 29 deletions docs/config/templates/indexPage.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,24 +84,24 @@
<div class="container">
<div class="row">
<div class="col-md-9 header-branding">
<a class="brand navbar-brand" href="http://angularjs.org">
<a class="brand navbar-brand" href="http://angularjs.org" title="AngularJS Home Page">
<img class="logo" src="img/angularjs-for-header-only.svg">
</a>
<ul class="nav navbar-nav">
<li class="divider-vertical"></li>
<li><a href="http://angularjs.org"><i class="icon-home icon-white"></i> Home</a></li>
<li><a href="http://angularjs.org" title="AngularJS Home Page"><i class="icon-home icon-white"></i> Home</a></li>
<li class="divider-vertical"></li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown">
<i class="icon-eye-open icon-white"></i> Learn <b class="caret"></b>
</a>
<ul class="dropdown-menu">
<li class="disabled"><a href="http://angularjs.org/">Why AngularJS?</a></li>
<li><a href="http://www.youtube.com/user/angularjs">Watch</a></li>
<li><a href="tutorial">Tutorial</a></li>
<li><a href="http://builtwith.angularjs.org/">Case Studies</a></li>
<li><a href="https://github.com/angular/angular-seed">Seed App project template</a></li>
<li><a href="misc/faq">FAQ</a></li>
<li class="disabled"><a href="http://angularjs.org/" title="Whay AngularJS?">Why AngularJS?</a></li>
<li><a href="http://www.youtube.com/user/angularjs" title="Watch videos">Watch</a></li>
<li><a href="tutorial" title="Tutorial">Tutorial</a></li>
<li><a href="http://builtwith.angularjs.org/" title="Cast Studies">Case Studies</a></li>
<li><a href="https://github.com/angular/angular-seed" title="Seed App project template">Seed App project template</a></li>
<li><a href="misc/faq" title="FAQ">FAQ</a></li>
</ul>
</li>
<li class="divider-vertical"></li>
Expand All @@ -110,12 +110,12 @@
<i class="icon-book icon-white"></i> Develop <b class="caret"></b>
</a>
<ul class="dropdown-menu">
<li><a href="tutorial">Tutorial</a></li>
<li><a href="guide">Developer Guide</a></li>
<li><a href="api">API Reference</a></li>
<li><a href="error">Error Reference</a></li>
<li><a href="misc/contribute">Contribute</a></li>
<li><a href="http://code.angularjs.org/">Download</a></li>
<li><a href="tutorial" title="Tutorial">Tutorial</a></li>
<li><a href="guide" title="Developer Guide">Developer Guide</a></li>
<li><a href="api" title="API Reference">API Reference</a></li>
<li><a href="error" title="Error Reference">Error Reference</a></li>
<li><a href="misc/contribute" title="Contribute">Contribute</a></li>
<li><a href="http://code.angularjs.org/" title="Download">Download</a></li>
</ul>
</li>
<li class="divider-vertical"></li>
Expand All @@ -124,15 +124,15 @@
<i class="icon-comment icon-white"></i> Discuss <b class="caret"></b>
</a>
<ul class="dropdown-menu">
<li><a href="http://blog.angularjs.org">Blog</a></li>
<li><a href="http://groups.google.com/group/angular">Mailing List</a></li>
<li><a href="http://webchat.freenode.net/?channels=angularjs&uio=d4">Chat Room</a></li>
<li><a href="http://blog.angularjs.org" title="Blog">Blog</a></li>
<li><a href="http://groups.google.com/group/angular" title="Mailing List">Mailing List</a></li>
<li><a href="http://webchat.freenode.net/?channels=angularjs&uio=d4" title="Chat Room">Chat Room</a></li>
<li class="divider"></li>
<li><a href="https://twitter.com/#!/angularjs">Twitter</a></li>
<li><a href="https://plus.google.com/110323587230527980117">Google+</a></li>
<li><a href="https://twitter.com/#!/angularjs" title="Twitter">Twitter</a></li>
<li><a href="https://plus.google.com/110323587230527980117" title="Google+">Google+</a></li>
<li class="divider"></li>
<li><a href="https://github.com/angular/angular.js">GitHub</a></li>
<li><a href="https://github.com/angular/angular.js/issues">Issue Tracker</a></li>
<li><a href="https://github.com/angular/angular.js" title="GitHub">GitHub</a></li>
<li><a href="https://github.com/angular/angular.js/issues" title="Issue Tracker">Issue Tracker</a></li>
</ul>
</li>
<li class="divider-vertical"></li>
Expand Down Expand Up @@ -163,7 +163,7 @@
<h4 class="search-results-group-heading">{{ key }}</h4>
<div class="search-results">
<div ng-repeat="item in value" class="search-result">
- <a ng-click="hideResults()" ng-href="{{ item.path }}">{{ item.name }}</a>
- <a ng-click="hideResults()" ng-href="{{ item.path }}" title="{{ item.name }}">{{ item.name }}</a>
</div>
</div>
</div>
Expand All @@ -186,7 +186,7 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
<ul class="nav-breadcrumb">
<li ng-repeat="crumb in breadcrumb" class="nav-breadcrumb-entry naked-list">
<span class="divider"> /</span>
<a ng-href="{{crumb.url}}">{{crumb.name}}</a>
<a ng-href="{{crumb.url}}" title="{{crumb.name}}">{{crumb.name}}</a>
</li>
</ul>
</div>
Expand All @@ -201,13 +201,13 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
<div class="side-navigation" ng-show="toc==true">
<ul class="nav-list naked-list">
<li ng-repeat="navGroup in currentArea.navGroups track by navGroup.name" class="nav-index-group">
<a href="{{ navGroup.href }}" ng-class="navClass(navGroup)" class="nav-index-group-heading">{{ navGroup.name }}</a>
<a href="{{ navGroup.href }}" ng-class="navClass(navGroup)" class="nav-index-group-heading" title="{{ navGroup.name }}">{{ navGroup.name }}</a>
<ul class="aside-nav">
<li ng-repeat="navItem in navGroup.navItems" ng-class="navClass(navItem)" class="nav-index-listing">
<a ng-if="navItem.extra.href" ng-class="navClass(navItem.extra)" href="{{navItem.extra.href}}">
<a ng-if="navItem.extra.href" ng-class="navClass(navItem.extra)" href="{{navItem.extra.href}}" title="{{navItem.extra.text}}">
{{navItem.extra.text}}<i ng-if="navItem.extra.icon" class="icon-{{navItem.extra.icon}}"></i>
</a>
<a tabindex="2" ng-class="linkClass(navItem)" href="{{navItem.href}}">{{navItem.name}}</a>
<a tabindex="2" ng-class="linkClass(navItem)" href="{{navItem.href}}" title="{{navItem.name}}">{{navItem.name}}</a>
</li>
</ul>
</li>
Expand All @@ -232,15 +232,15 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
Super-powered by Google ©2010-2014
( <a id="version"
ng-href="https://github.com/angular/angular.js/blob/master/CHANGELOG.md#{{versionNumber}}"
ng-bind-template="v{{version}}">
ng-bind-template="v{{version}}" title="v{{version}}">
</a>
)
</p>
<p>
Code licensed under the
<a href="https://github.com/angular/angular.js/blob/master/LICENSE" target="_blank">The
<a href="https://github.com/angular/angular.js/blob/master/LICENSE" target="_blank" title="The MIT License">The
MIT License</a>. Documentation licensed under <a
href="http://creativecommons.org/licenses/by/3.0/">CC BY 3.0</a>.
href="http://creativecommons.org/licenses/by/3.0/" title="CC BY 3.0">CC BY 3.0</a>.
</p>
</div>
</footer>
Expand Down
2 changes: 1 addition & 1 deletion docs/content/misc/faq.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Conditionally showing and hiding things using jQuery is a common pattern in othe
`ng-show` (and `ng-hide`) conditionally show and hide elements based on boolean expressions.
Describe the conditions for showing and hiding an element in terms of `$scope` variables:

<div ng-show="!loggedIn">Click <a href="#/login">here</a> to log in</div>
<div ng-show="!loggedIn">Click <a href="#/login" title="login">here</a> to log in</div>

Note also the counterpart `ng-hide` and similar `ng-disabled`.
Note especially the powerful `ng-switch` that should be used instead of several mutually exclusive `ng-show`s.
Expand Down
2 changes: 1 addition & 1 deletion docs/content/tutorial/step_00.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ npm install

To see the app running in a browser, open a *separate* terminal/command line tab or window, then
run `npm start` to start the web server. Now, open a browser window for the app and navigate to
<a href="http://localhost:8000/app/index.html" target="_blank">`http://localhost:8000/app/index.html`</a>
<a href="http://localhost:8000/app/index.html" target="_blank" title="Open App Locally">`http://localhost:8000/app/index.html`</a>

You can now see the page in your browser. It's not very exciting, but that's OK.

Expand Down
2 changes: 1 addition & 1 deletion docs/content/tutorial/step_06.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ __`app/index.html`:__
<ul class="phones">
<li ng-repeat="phone in phones | filter:query | orderBy:orderProp" class="thumbnail">
<a href="#/phones/{{phone.id}}" class="thumb"><img ng-src="{{phone.imageUrl}}"></a>
<a href="#/phones/{{phone.id}}">{{phone.name}}</a>
<a href="#/phones/{{phone.id}}" title="{{phone.name}}">{{phone.name}}</a>
<p>{{phone.snippet}}</p>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion docs/content/tutorial/step_07.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ __`app/partials/phone-list.html`:__
<ul class="phones">
<li ng-repeat="phone in phones | filter:query | orderBy:orderProp" class="thumbnail">
<a href="#/phones/{{phone.id}}" class="thumb"><img ng-src="{{phone.imageUrl}}"></a>
<a href="#/phones/{{phone.id}}">{{phone.name}}</a>
<a href="#/phones/{{phone.id}}" title="{{phone.name}}">{{phone.name}}</a>
<p>{{phone.snippet}}</p>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion docs/content/tutorial/step_12.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ __`app/partials/phone-list.html`.__
<li ng-repeat="phone in phones | filter:query | orderBy:orderProp"
class="thumbnail phone-listing">
<a href="#/phones/{{phone.id}}" class="thumb"><img ng-src="{{phone.imageUrl}}"></a>
<a href="#/phones/{{phone.id}}">{{phone.name}}</a>
<a href="#/phones/{{phone.id}}" title="{{phone.name}}">{{phone.name}}</a>
<p>{{phone.snippet}}</p>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion src/ngScenario/output/Html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ angular.scenario.output('html', function(context, runner, model) {
runner.on('InteractivePause', function(spec) {
var ui = lastStepUiMap[spec.id];
ui.find('.test-title').
html('paused... <a href="javascript:resume()">resume</a> when ready.');
html('paused... <a href="javascript:resume()" title="resume">resume</a> when ready.');
});

runner.on('SpecBegin', function(spec) {
Expand Down