Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Adds titles to various links in docs and src for improved accessibility. #7932

Closed
wants to merge 1 commit into from

Conversation

sndsgn
Copy link

@sndsgn sndsgn commented Jun 22, 2014

No description provided.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@sndsgn sndsgn added cla: no and removed cla: yes labels Jun 22, 2014
@sndsgn
Copy link
Author

sndsgn commented Jun 22, 2014

Emails match. I just looked at my GitHub profile to confirm and signed the
CLA again. Is there anything else that I should check?

On Sat, Jun 21, 2014 at 9:10 PM, Mary Poppins [email protected]
wrote:

I'm sorry, but I wasn't able to verify your Contributor License Agreement
(CLA) signature. CLA signature is required for any code contributions to
AngularJS.

Please sign our CLA
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla
and ensure that the CLA signature email address and the email address in
this PR's commits match
.

If you signed the CLA as a corporation, please let us know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses
don't match. Please sign the CLA again or update the email address in the
commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA
verification process.


Reply to this email directly or view it on GitHub
#7932 (comment).

@marcysutton
Copy link
Contributor

Most of these title attributes are unnecessarily redundant. The only time they are useful is when the link text doesn't describe what the link will do (like "click here" or "http://localhost/"), or if it opens in a new window.

@Narretz Narretz closed this in 41385f0 Jun 4, 2015
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants