Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(ngLocale): fix ngLocale scripts and update #7668

Closed
wants to merge 3 commits into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Jun 2, 2014

Fixes #7628 and probably other issues as well.

…t code.google.com

The closure-library migrated a while ago, so the script would fail. This is change
should allow us to update these more frequently.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7668)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@IgorMinar
Copy link
Contributor

it seems that the generated locale files now depend on goog.i18n.pluralRules.get_vf_ to be available. As far as I can tell, we don't expose it, so this will throw NPE at runtime.

Have you tried to run the manual e2e tests located at: https://github.com/angular/angular.js/tree/master/i18n/e2e ?

@caitp
Copy link
Contributor Author

caitp commented Jun 2, 2014

Yes -- I mentioned this in the flow, and I'm seeing if it can be worked around :>

caitp added 2 commits June 2, 2014 14:22
…, and get_wt_

The updated Closure I18N code relies on these methods to enhance the localization quality.

This fix prevents ngLocale files from referencing undefined values. In the short term, this
means adding references to versions of these methods in locales where they are necessary.
This is a batch of updated ngLocale scripts, based on the recent fixes.
@caitp caitp added this to the 1.3.0 milestone Jun 2, 2014
@IgorMinar
Copy link
Contributor

lgtm

@caitp
Copy link
Contributor Author

caitp commented Jun 2, 2014

Okay, I'm going to merge this for now, but I'll try to figure out how to change the source to just use CLDR directly in a bit

@caitp caitp closed this in 36a0e59 Jun 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants