Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore($ngLocale): Added nb-no and no-no locale files #7628

Closed
wants to merge 1 commit into from

Conversation

intellix
Copy link
Contributor

Request Type: chore

How to reproduce:

Component(s): ngLocale

Impact: small

Complexity: small

This issue is related to: Missing locale files

Detailed Description: ngLocale is missing the nb-NO and no-NO locale files in use by norwegian browsers. These also exist in Google Closure Library by the looks of it.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7628)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@lgalfaso
Copy link
Contributor

lgalfaso commented Jun 2, 2014

locales are updated using i18n/update-closure.sh and this uses https://closure-library.googlecode.com
Is this locale present there?

@caitp
Copy link
Contributor

caitp commented Jun 2, 2014

It's on github now https://github.com/google/closure-library/tree/master/closure/goog/i18n --- and it looks like there is an 'nb' locale at least.

But we don't update the i18n library during each release, for some reason

https://github.com/google/closure-library/blob/5e41fdc8a6bacac748ea8d9924f23f714cb23da8/closure/goog/i18n/numberformatsymbols.js#L3876 / https://github.com/google/closure-library/blob/5e41fdc8a6bacac748ea8d9924f23f714cb23da8/closure/goog/i18n/numberformatsymbols.js#L3904

So there's a bit of support for these, although I don't see them too many other places.

@intellix
Copy link
Contributor Author

intellix commented Jun 2, 2014

If I do window.navigator.language on my norwegian colleague's browser I get nb-NO and he mentioned that it's "new" Norwegian spoken by the current generation. I added the no-NO as well since there's the same for the other nordic locales (Swedish, Finnish etc) and am using that format to dynamically load the correct ngLocale with https://github.com/lgalfaso/angular-dynamic-locale. From wikipedia: Bokmål is the preferred written standard of Norwegian for 85–90%

@caitp
Copy link
Contributor

caitp commented Jun 2, 2014

@intellix so the files we generate from the current i18n library have nb-no and no-no --- but the script is broken ATM because the closure library moved to github.

So I'm going to submit a PR to fix the script, and we should be able to run this for every release in the future --- but someone internal needs to make the changes to the release scripts, I think.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@intellix intellix added cla: no and removed cla: yes labels Jun 5, 2014
@btford
Copy link
Contributor

btford commented Jun 9, 2014

This has since been fixed. Closing.

@btford btford closed this Jun 9, 2014
@intellix intellix deleted the ngLocale-norsk branch June 10, 2014 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants