docs(ngController): Add in more description of controller as #7604
Conversation
Using `controller as` in the template is not described well in the docs, as both `scope` injection and `this` are presented equally without too much discussion of the advantages of using either. I added a bit more discussion based on google's internal style guidelines. Should close angular#5076 until Angular 2.0 comes out and we refactor everything.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
@petebacondarwin added |
| * to the controller and avoiding scope. Using `controller as` makes it obvious which controller | ||
| * you are accessing in the template when multiple controllers apply to an element. Since there | ||
| * is always a `.` in the bindings, you don't have to worry about prototypal inheritance masking | ||
| * primitives. |
There was a problem hiding this comment.
this is good information, but I'm not sure it's presented in a very accessible way --- it feels like it's dumping a whole pile of information onto a (likely new) user who maybe doesn't know what prototype inheritance even is.
Do you think we could make this a bit more accessible? /cc @btford
There was a problem hiding this comment.
Agreed. Any help would be great.
|
Sorry I landed and improved this a while back. |
Using
controller asin the template is not described wellin the docs, as both
scopeinjection andthisare presentedequally without too much discussion of the advantages of using
either. I added a bit more discussion based on google's internal
style guidelines.
Should implement changes suggested in #7591. Let me know if you
need a separate PR.