This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngController): Add in more description of controller as #7591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `controller as` in the template is not described well in the docs, as both `scope` injection and `this` are presented equally without too much discussion of the advantages of using either. I added a bit more discussion based on google's internal style guidelines. Should close angular#5076 until Angular 2.0 comes out and we refactor everything.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| * easily be called from the angular markup. Any changes to the data are automatically reflected | ||
| * in the View without the need for a manual update. | ||
| * | ||
| * Two different declaration styles are included below: one which injects `scope` into the |
There was a problem hiding this comment.
should be "injects $scope", no?
petebacondarwin
added a commit
that referenced
this pull request
May 27, 2014
… example Adds to #7591
petebacondarwin
pushed a commit
that referenced
this pull request
May 27, 2014
Using `controller as` in the template is not described well in the docs, as both `scope` injection and `this` are presented equally without too much discussion of the advantages of using either. I added a bit more discussion based on google's internal style guidelines. Closes #7591 Closes #5076 (until Angular 2.0 comes out and we refactor everything)
petebacondarwin
added a commit
that referenced
this pull request
May 27, 2014
… example Adds to #7591
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
controller asin the template is not described wellin the docs, as both
scopeinjection andthisare presentedequally without too much discussion of the advantages of using
either. I added a bit more discussion based on google's internal
style guidelines.
Should close #5076 until Angular 2.0 comes out and we refactor
everything.