Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

#5001: Fixes jqLite not appropriately adding and removing classes for IE... #5669

Closed
wants to merge 9 commits into from
Closed

#5001: Fixes jqLite not appropriately adding and removing classes for IE... #5669

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0886611
#5001: Fixes jqLite not appropriately adding and removing classes for…
Jan 7, 2014
c3b4531
Fixed bad logic in jqLiteRemoveClass, added SVG check in jqLiteAddClass
Jan 8, 2014
9878f54
Added dummy space
Jan 8, 2014
796d925
Removed dummy space
Jan 8, 2014
3f04e8f
Proposed fix for getting class name in IE9
Jan 8, 2014
33ec201
Added logic for jqLiteHasClass
Jan 8, 2014
523efea
loosened condition
Jan 8, 2014
4c69172
Removed excessive check
Jan 8, 2014
bce2deb
Made condition strict again
Jan 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/jqLite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,20 @@ function jqLiteRemoveClass(element, cssClasses) {
);
});
}
else if (msie === 9) {
forEach(cssClasses.split(' '), function(cssClass) {
element.className = trim(
(" " + (element.className || '') + " ")
.replace(/[\n\t]/g, " ")
.replace(" " + trim(cssClass) + " ", " ")
);
});
}
}

function jqLiteAddClass(element, cssClasses) {
if (cssClasses && element.setAttribute) {
var existingClasses = (' ' + (element.getAttribute('class') || '') + ' ')
var existingClasses = (' ' + (element.getAttribute('class') || element.className || '') + ' ')
.replace(/[\n\t]/g, " ");

forEach(cssClasses.split(' '), function(cssClass) {
Expand All @@ -322,7 +331,8 @@ function jqLiteAddClass(element, cssClasses) {
}
});

element.setAttribute('class', trim(existingClasses));
(msie === 9 && !(element instanceof SVGElement)) ? element.className = trim(existingClasses) :
element.setAttribute('class', trim(existingClasses));
}
}

Expand Down