Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

#5001: Fixes jqLite not appropriately adding and removing classes for IE... #5669

Closed
wants to merge 9 commits into from

Conversation

wesleycho
Copy link
Contributor

...9

This should address #5001 (tested it in a project on a Windows 7 VM with IE9), although I may not have crafted the most efficient fix - suggestions for refactoring are welcome.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@wesleycho
Copy link
Contributor Author

Just noting here, a bunch of tests are currently broken in IE9, likely due to there being a check whether setAttribute is a function & perhaps some jqLite specific tests pertaining to adding & removing classes. I'm still looking into it, although this will be a bit tricky to fix completely. Likely will force push a new version with squashed commits once I figure it out.

@ghost ghost assigned tbosch Jan 8, 2014
@wesleycho
Copy link
Contributor Author

Reintroduced in #5686

@wesleycho wesleycho closed this Jan 8, 2014
@wesleycho wesleycho deleted the jqlite_ie9_class branch January 8, 2014 18:02
@wesleycho wesleycho restored the jqlite_ie9_class branch January 8, 2014 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants