This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(deeplinking.ngdoc): correct and enhance deep linking demo #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "#/" linking Implement ability to add and remove contacts Use semantic tags Closes angular#3870
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
ghost
assigned 
|
Tests don't pass and there are issues with this. We need to re-evaluate our docs WRT these cookbook examples. Going to close for now. @jamesdaily if you fix the tests, we can re-open this and discuss it more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "#/" linking
Implement ability to add and remove contacts
Use semantic tags
Closes #3870